Skip to content

JosiahTucker/issue68 - #313

Open
JosiahTucker wants to merge 2 commits into
mainfrom
JosiahTucker/issue68
Open

JosiahTucker/issue68#313
JosiahTucker wants to merge 2 commits into
mainfrom
JosiahTucker/issue68

Conversation

@JosiahTucker

Copy link
Copy Markdown
Collaborator

Fixes #68

Description

I adjusted the code to plot the data as well as format the data in a way the plot can read.

Relevant issue(s)

Questions

Box and whisker plot was not added and only the histogram i could not get anything to work on the box and whisker

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • [ X] I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have assigned reviewers to this PR

@HamzahSaleh HamzahSaleh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR updatedReact/React‑DOM
"nx": "^18.3.5", "react": "^19.1.0", "react-dom": "^19.1.0",
to 19.1.0, but our packages including react google charts said to be used in the issue, only support React 17/18. As a result, npm install would be broken for everyone else.

revert react and react-dom in package.json back to the previous version then commit your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add visualizations to NumericQuestionAnalytics component

3 participants