api component - #203
Open
ianinnes1 wants to merge 7 commits into
Open
Conversation
andlrutt
previously requested changes
Apr 22, 2024
andlrutt
left a comment
andlrutt
left a comment
Member
There was a problem hiding this comment.
Looking good! Just update the 404 to be a 400 (and maybe include some messages if you'd like!) and then also check the return value of createFormQuestions and return a 404 error if it's null.
LSmith2174
previously requested changes
Apr 26, 2024
LSmith2174
left a comment
LSmith2174
left a comment
Contributor
There was a problem hiding this comment.
just a tiny little fix and then it's all good to go!
changed error messages
debugging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Relevant issue(s)
Questions
Type of change
Checklist: