Fix bug de submit de form vazio - #16
Open
luchesigui wants to merge 14 commits into
Open
Conversation
degrecci
requested changes
Oct 30, 2018
Contributor
Author
|
Externalizei a validação em uma função que aceita um array de campos a ser validados e os campos preenchidos |
degrecci
approved these changes
Nov 19, 2018
victormiguez
requested changes
Feb 1, 2019
victormiguez
left a comment
victormiguez
left a comment
Collaborator
There was a problem hiding this comment.
@guiluchesi desculpa a demora infinita para revisar ): tenho só duas observações para corrigir.
| "react": "^16.5.2", | ||
| "react-dom": "^16.5.2", | ||
| "react-scripts": "2.0.5", | ||
| "styled-components": "^4.0.2" |
Collaborator
There was a problem hiding this comment.
Faltou uma virgulinha aqui.
| import InitiativeList from './components/InitiativeList'; | ||
|
|
||
| const isFormFilled = (values, requiredFields) => !requiredFields | ||
| .map(field => values[field] ? true : false) |
Collaborator
There was a problem hiding this comment.
Que tal mudar para field => Boolean(values[field])?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.