test(coverage): restore to ~99.6/99.0/99.9/99.9 + gate coverage in CI - #57
Merged
Conversation
Coverage had slid to 97.69/93.45/96.39/98.89 unnoticed (Vitest 2->4 remap changes in #54 plus untested-code drift) because CI ran test:unit, never the thresholds. This restores it above the original v0.0.48 baseline and makes regression impossible to miss: - ~400 new tests across 5 parallel clusters (Inspector/editor panels, meters, plugins+llm+formula, lib/core, canvas+widgets misc): 2769 -> 3151 tests. Inspector.tsx alone went 81.1% -> 99.7% stmts. All test-only; no source changes, no coverage-ignore pragmas (standing policy). Residue is documented unreachable defensive arms / library-internal branches, each justified in the PR notes. - CI client job now runs test:coverage instead of test:unit, so the vite.config ratchet gates every PR. - Thresholds re-ratcheted: statements 99->99.25, lines 99->99.5, functions 96->99.5, branches 95->98.5 (~0.4pp slack for cross-platform v8 remap jitter). - Also hardened one pre-existing flaky test (MonitorSourcesEditor rescan raced a disabled button under parallel load). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coverage had slid to 97.69 / 93.45 / 96.39 / 98.89 unnoticed (Vitest 2→4 remap changes in #54 plus untested-code drift) because CI ran `test:unit` but never the thresholds. This PR restores it above the original v0.0.48 baseline and makes regression impossible to miss.
What's in it
Verification
Final tree: `tsc` clean, oxfmt+oxlint clean, 3,151 tests / 276 files pass, build clean, coverage gate exit 0 at the new floors. Global: 99.62 stmts / 98.97 branches / 99.91 funcs / 99.93 lines.
No product code changed → no release from this PR (per instruction).
🤖 Generated with Claude Code