automation: unified pr-pipeline and release-pipeline#99
Merged
Conversation
roddyrap
approved these changes
Jun 5, 2026
|
|
||
| - name: Build | ||
| run: make build-${{ matrix.architecture }}-${{ matrix.build_type }} -j$((`nproc`+1)) | ||
| run: make build-${{ matrix.architecture }}-${{ matrix.build_type }} -j$(($(nproc)+1)) |
Collaborator
There was a problem hiding this comment.
Shouldn't this be '-1'? nproc + 1 doesn't make sense
Owner
Author
There was a problem hiding this comment.
yeah idk why it was +1, it was a rule i learned from someone a long time ago, but it is probably wrong. lets just do nproc...
Collaborator
There was a problem hiding this comment.
I agree. I learned -1 because you still want a free thread to do other things on your PC but this is an automation machine so you jut don't need it.
guyush1
force-pushed
the
testing-automation
branch
4 times, most recently
from
f9c0a9d to
d4789ac
Compare
This has the added benefit that the releases will use the build matrix, resulting in quicker releases.
guyush1
force-pushed
the
unify-automation-pipelines
branch
from
2761ee3 to
ec4b3df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has the added benefit that the releases will use the build matrix, resulting in quicker releases.