feat(ios): integrate new iOS screens and fix simulator linking - #37
Merged
Conversation
- Integrate event detail experience and transport plan views without changing tab bar navigation - Migrate affected iOS views to Shared domain types (Event_, TimeSlot_, Vote_) - Fix pre-existing AddToCalendarButton preview constructor errors - Update repository wiring and preview factory for current Shared APIs - Exclude x86_64 for iOS simulator to avoid Kotlin Shared framework link failures Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 825dd67fe9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the iOS SwiftUI navigation and UI to introduce a new event-detail “experience” screen (plus a transport sub-screen), adjusts Inbox labeling/content, refreshes preview/test factories, and tweaks Xcode build settings to address simulator linking issues.
Changes:
- Adds
EventDetailExperienceView(andTransportPlanView) and wires it intoContentViewrouting for the.eventDetailcase. - Updates Inbox tab title / filter chip labels to reflect the “Messages” experience.
- Refactors multiple views/view-models/preview factories to use underscored Shared types (
Event_,TimeSlot_,Vote_) and updates previews (notablyAddToCalendarButton).
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 48 comments.
Show a summary per file
| File | Description |
|---|---|
| iosApp/src/Views/PollVotingView.swift | Updates poll voting UI types and vote submission wiring to new Shared model types. |
| iosApp/src/Views/PollResultsView.swift | Updates poll results UI types and organizer confirm flow to new Shared model types. |
| iosApp/src/Views/ParticipantManagementView.swift | Updates participant management view’s event type. |
| iosApp/src/Views/InboxView.swift | Renames Inbox navigation title to “Messages” and adjusts filter chip labels. |
| iosApp/src/Views/HomeView.swift | Updates Home events list/carousel types and selection callback signature. |
| iosApp/src/Views/EventDetailExperienceView.swift | Adds the new event detail experience screen and a transport planning screen. |
| iosApp/src/Views/CreateEventSheet.swift | Updates the created-event callback type and the constructed shared event type. |
| iosApp/src/ViewModels/EventDetailViewModel.swift | Updates selected event type and update intent signature. |
| iosApp/src/Services/RepositoryProvider.swift | Updates repository initialization (user repository type) for sync wiring. |
| iosApp/src/Preview/Factories/EventFactory.swift | Refactors preview event/time-slot factory to new Shared types and APIs. |
| iosApp/src/ContentView.swift | Wires new event detail experience + transport route; updates event types used throughout navigation. |
| iosApp/src/Components/AddToCalendarButton.swift | Updates preview event construction for current Shared APIs. |
| iosApp/iosApp.xcodeproj/project.pbxproj | Excludes x86_64 for iOS simulator builds to avoid Shared framework link failures. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Show Vote action only for polling events with slots and show Results for non-draft events - Disable vote/results tile when no proposed slots are available - Prevent empty-slot poll flow from submitting a false-success vote state Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add missing French accents in event detail and transport labels - Localize inbox filter chip labels via String(localized:) - Fix Borély accent in preview fixture text Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aligns the iOS app with the new screen vision while keeping the existing tab bar/navigation model intact, and resolves pre-existing build blockers that prevented reliable simulator runs.
What changed
EventDetailExperienceView) and wired navigation from existing home/detail entry points without changing the current navbar/tabbar structure.Event_,TimeSlot_,Vote_) so view, view-model, and repository calls are consistent.AddToCalendarButtonand refreshed preview factory/repository wiring for current shared APIs.x86_64for simulator builds to avoid KotlinSharedframework undefined-symbol link failures.Notes for reviewers