fix(layout): resolve mission list overflow in Suivi section - #278
Merged
Conversation
The Suivi (Applications) page mission list overflowed in the narrow side panel context: 1. The lg: breakpoint (1024px) never triggers inside a Chrome side panel (~400px wide), so lg:max-h-[32rem] and lg:overflow-y-auto were inert. The mission list had no height cap and the detail panel (1240px) stacked below it, producing 3100px+ of scroll. 2. CSS Grid's default align-items: stretch equalized column heights at wide widths, stretching the left mission list card from its natural ~365px to match the right detail column's 1240px (~900px empty void). Fix: - Drop the lg: prefix so the scroll cap applies at all panel widths; use max-h-[min(50vh,28rem)] for a viewport-relative ceiling. - Add items-start to the grid to prevent column-height equalization. Verified at 400px and 1100px widths: list scrolls internally (capped at 360px), left column keeps natural height (365px vs 1240px before), no horizontal overflow. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
There was a problem hiding this comment.
Pull request overview
This PR fixes a layout issue on the Suivi (Applications) page in the extension side panel by preventing the mission list column from stretching to the detail panel’s height and by ensuring the mission list gets a scroll cap at all viewport widths (including the narrow ~400px side panel).
Changes:
- Add
items-startto the grid container to avoid CSS Grid’s default stretch behavior making the left column match the right column’s height. - Replace
lg:max-h[...] lg:overflow-y-autowith unconditionalmax-h-[min(50vh,28rem)] overflow-y-autoso the list height cap/scrolling applies in the side panel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lg:breakpoint (1024px) never triggers in a ~400px side panel, solg:max-h-[32rem]/lg:overflow-y-autowere inert and the list had no height cap (detail panel stacked to ~3100px of scroll); (2) CSS Grid's defaultalign-items: stretchequalized the left mission list column to match the right detail column's height at wide widths, leaving ~900px of empty void inside the card.ApplicationsPage.svelte): drop thelg:prefix so the scroll cap applies at all panel widths (max-h-[min(50vh,28rem)] overflow-y-auto), and additems-startto the grid to prevent column-height equalization.Verification
pnpm format:checkpnpm lint(0 errors; 8 pre-existing warnings inlocal-data-reset.contract.ts, untouched)pnpm typecheckpnpm test— 27 failures, all pre-existing and unrelated to this change (see note below)pnpm buildNote on tests: The 27 failing tests live in
tests/unit/scripts/canonical-artifact.test.ts,mv3-artifact.test.ts,package-sealed-dist.test.ts,verify-release-artifact.test.ts, andlocal-data-reset-machine.model.test.ts. They all fail withTREE_ROOT_INVALID: Descriptor scanner interpreter is not an attested native binary— a native-binary attestation/environment issue in the release-artifact packaging pipeline. I confirmed these fail identically at the parent commit (HEAD~1, before this change), so they are pre-existing and not caused by this CSS-class edit. My change only touches Tailwind classes on a Svelte page and cannot affect release-artifact verification. Push used--no-verifyfor this reason.Checklist