Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #201: this is one of the fixes from it, on Bubble Tea.
With a filter applied,
l/hin the article view open the wrong article.list.Index()counts the filtered rows, but next and prev indexedlist.Items(), which is every row. Filter to two articles with another one between them in the full list, and next opens the one in between.Switching to
VisibleItems()isn't enough on its own. Opening an article callsUpdateList, and a filtered list then refilters in the background. TheFilterMatchesMsgarrived while the article view was showing, so it went to the viewport and was dropped. In the article view the list had no visible rows, and next and prev did nothing.Updatenow handsFilterMatchesMsgto the list whichever view is showing.Before / after, with three articles where the filter
golangshows two:Checked by running nom in a pty against a local feed, and with
TestNextAndPrevFollowTheFilteredList. The test drives the model throughUpdatethe way the program does: it types the filter, opens an article, presseslandh, and runs the commands they return. It fails on master, and it also fails with only theVisibleItems()half of the change.Not changed here:
m(mark read) in the article view still takes its undo backup fromlist.Items()by the filtered index. It has the same mix-up, but fixing it touches bubbles'RemoveItem/InsertItem, which are themselves unfiltered-index based, so I left it for a separate change.