Skip to content

fix: f in the article view favourites without paging down - #203

Open
thebanri wants to merge 1 commit into
guyfedwards:masterfrom
thebanri:fix-viewport-f
Open

thebanri wants to merge 1 commit into
guyfedwards:masterfrom
thebanri:fix-viewport-f

Conversation

@thebanri

@thebanri thebanri commented Oct 4, 2026

Copy link
Copy Markdown

Following up on #201: this is one of the fixes from it, on Bubble Tea.

In the article view, f favourites the article, and then the same key goes on to the viewport. bubbles' default viewport key map binds f to page down, so favouriting also jumped a page.

This drops f from the viewport's page down binding. Page down stays on pgdn and space, and the help line says so. Nothing else in the viewport key map collides with nom's keys (h, l, g, G, m, o, q).

Before / after: in a long article, press f. On master the screen lands on paragraph 10. With this change it stays at the title. Both mark the article as a favourite. Checked by running nom in a pty against a local feed. TestFavouriteInArticleDoesNotPageDown fails on master, and TestSpaceStillPagesDownInArticle checks that space still works.

Copilot AI balanced review requested due to automatic review settings October 4, 2026 22:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants