Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #201: this is one of the fixes from it, on Bubble Tea.
Feeds often use relative links and image sources (
/doc/,next/,../). nom converted them with an empty domain, so they stayed relative. They were neither clickable nor useful to copy. This resolves them against the article's own link withurl.ResolveReference, the way a browser would.The converter's built-in
domainoption wouldn't do it. It only sets the host, forceshttp, and gets path-relative URLs (next/,../) wrong. Absolute URLs,mailto:anddata:are left as they are. If the article has no absolute link, nothing changes.Before → after, for an article at
http://127.0.0.1:7781/blog/g1/:goquerymoves from indirect to direct ingo.mod, because the option's function type names it. It was already in the module graph.Tested with a table test (root-relative, path-relative,
../, fragment,//hostimage, relative image, absolute, mailto), which fails on master. Also checked by hand: built nom, ran it in a pty against a local feed, and read the article screen.