Fix tag links for terms with special characters (e.g. C#) - #262
Open
markheydon wants to merge 1 commit into
Open
Fix tag links for terms with special characters (e.g. C#)#262markheydon wants to merge 1 commit into
markheydon wants to merge 1 commit into
Conversation
Use GetTerms + RelPermalink instead of urlize so taxonomy links match Hugo term pages. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
urlizeon the raw tag string, which strips#(and mishandles similar characters), soC#linked to/tags/cand 404'd.layouts/_default/single.htmlto.GetTerms "tags"+.RelPermalink+.LinkTitleso links match Hugo’s generated taxonomy term pages (e.g./tags/c%23/).openInNewTabdefault astrue.Fixes #261
Test plan
tags: ["C#"]/tags/c%23/(not/tags/c)Made with Cursor