Skip to content

Fix/add object error handling#10

Open
toshiya wants to merge 2 commits into
guillec:masterfrom
toshiya:fix/add_object_error_handling
Open

Fix/add object error handling#10
toshiya wants to merge 2 commits into
guillec:masterfrom
toshiya:fix/add_object_error_handling

Conversation

@toshiya

@toshiya toshiya commented May 28, 2016

Copy link
Copy Markdown

Fix for the CI problmes in #9

toshiya added 2 commits May 24, 2016 23:35
4.1.  add
When the operation is applied, the target location MUST reference

4.2. remove
The target location MUST exist for the operation to be successful.
1. fix for the parallel execution in the latest test-unit.
2. specify rake version in Gemfile for ruby 1.9.2 because the latest
rake requires > ruby 1.9.3.
@coveralls

coveralls commented May 28, 2016

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 010e085 on toshiya:fix/add_object_error_handling into d3a33b0 on guillec:master.

@toshiya

toshiya commented May 28, 2016

Copy link
Copy Markdown
Author

@guillec

Now CI passed. Thank you for your reviews.

@toshiya

toshiya commented Jun 4, 2016

Copy link
Copy Markdown
Author

@guillec

How about this PR?

This PR contains the fix for the following error cases specified in the RFC.

4.1. add
When the operation is applied, the target location MUST reference
https://tools.ietf.org/html/rfc6902#section-4.1

4.2. remove
The target location MUST exist for the operation to be successful.
https://tools.ietf.org/html/rfc6902#section-4.2

@guillec

guillec commented Jun 6, 2016

Copy link
Copy Markdown
Owner

@toshiya will look at this this week. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants