Repository navigation
typescript-deno: Fix failing test, watch-mode default, and update imports for Deno 2 - #158
Open
adamnfish-gu wants to merge 1 commit into
Open
adamnfish-gu wants to merge 1 commit into
adamnfish-gu wants to merge 1 commit into
Conversation
The example test asserted result === true but mod.ts exported false. It now exports true. script/test ran `deno test --watch`, which never exits. It now runs once, with the watch loop behind --watch. The std assert import from deno.land/std@0.153.0 does not resolve on Deno 2; the module moved to jsr:@std/assert. deno.lock updated to match. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Aug 7, 2026
Contributor
Author
|
Deno is now end of life, so I don't think it should be a huge priority to merge this PR stack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example test asserted result === true but mod.ts exported false. It now exports true.
script/test ran
deno test --watch, which never exits. It now runs once, with the watch loop behind --watch.The std assert import from deno.land/std@0.153.0 does not resolve on Deno 2; the module moved to jsr:@std/assert. deno.lock updated to match.
Base
platform/tool-versions-ci(#144), so the diff shows only this branch's changes. Merge #144 first.Part of #143.