Repository navigation
java: Declare the java toolchain in .tool-versions - #147
Open
adamnfish-gu wants to merge 1 commit into
Open
adamnfish-gu wants to merge 1 commit into
adamnfish-gu wants to merge 1 commit into
Conversation
script/setup installed maven via brew, which is macOS-only. It now resolves dependencies. script/test and script/run cd to the project root so they work from any directory, matching the other skeletons. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
emdash-ie
reviewed
Oct 9, 2026
| fi No newline at end of file | ||
| cd "$(dirname "${BASH_SOURCE[0]}")/.." | ||
|
|
||
| mvn --quiet dependency:resolve |
There was a problem hiding this comment.
Running this script gives no output at all, which was a bit disconcerting. I think this is because of the --quiet flag: would we consider removing it? Maven does print a lot of output when installing things, but I think I prefer that to no output at all.
emdash-ie
reviewed
Oct 9, 2026
|
|
||
| cd "$(dirname "${BASH_SOURCE[0]}")/.." | ||
|
|
||
| mvn test |
There was a problem hiding this comment.
I wondered why the --quiet flag wasn’t used here, so I experimented: looks like if you add the flag you don’t even get "test passed", so it’s definitely better without.
emdash-ie
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
script/setup installed maven via brew, which is macOS-only. It now resolves dependencies.
script/test and script/run cd to the project root so they work from any directory, matching the other skeletons.
Base
platform/tool-versions-ci(#144), so the diff shows only this branch's changes. Merge #144 first.Part of #143.