Skip to content
This repository was archived by the owner on May 14, 2026. It is now read-only.

Fixed NavBar - #57

Merged
Alfredcrmn merged 2 commits into
mainfrom
fixedNavBar
Nov 11, 2025
Merged

Alfredcrmn merged 2 commits into
mainfrom
fixedNavBar

Conversation

@Alfredcrmn

Copy link
Copy Markdown
Collaborator

The NavBar is now fixed, so when the user scrolls down, it remains at the top of the viewport.

Added a z-index of 1000 to ensure the NavBar stacks at the top of the page's elements.

Added CSS for the NavBar to be fixed. It works both on PC and Mobile.
@github-actions

github-actions Bot commented Nov 5, 2025

Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-sea-0d048991e-57.westus2.6.azurestaticapps.net

@hanrodz
hanrodz self-requested a review November 6, 2025 04:26
@hanrodz hanrodz closed this Nov 6, 2025
@hanrodz hanrodz reopened this Nov 6, 2025
@github-actions

github-actions Bot commented Nov 6, 2025

Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-sea-0d048991e-57.westus2.6.azurestaticapps.net

@hanrodz hanrodz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good but when navigating to the different sections the headers are cropped. The added spacing should be accounted for.

Not very familiar with the navigation bar implementation but I think the fix might be in or around layouts/App.tsx.

Screenshot of Partners section where the header is cropped Screenshot of FAQ section where the header is cropped

added scroll-padding-top. sync spacer height and z-index with global.css values
@Alfredcrmn
Alfredcrmn requested a review from hanrodz November 6, 2025 22:35
@github-actions

github-actions Bot commented Nov 6, 2025

Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-sea-0d048991e-57.westus2.6.azurestaticapps.net

@hanrodz hanrodz left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hanrodz hanrodz linked an issue Nov 7, 2025 that may be closed by this pull request
@hanrodz

hanrodz commented Nov 7, 2025 •

Copy link
Copy Markdown
Member

@Alfredcrmn feel free to merge as soon as the required checks succeed 😸

@Alfredcrmn
Alfredcrmn merged commit f18ad13 into main Nov 11, 2025
3 of 4 checks passed
@Alfredcrmn
Alfredcrmn deleted the fixedNavBar branch November 11, 2025 22:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Navbar not persistent on screen

2 participants