Restore lockstep frame semantics#118
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This restores conservative lockstep semantics for
max_prediction = 0.In lockstep mode, GGRS now keeps
current_frame()as the public game frame, does not emit rollback save/load requests, and only advances when the current frame has confirmed inputs from all players. Stalled lockstep frames returnOk(vec![])without consuming a game frame.Using this with the recommended game loops for rollback will result in phaselocked clients that require at least RTT input delay to operate smoothly. By changing the gameloop, users should be able to only require single-way delay for smooth operation.
This PR also adds optional bounded wait helpers:
advance_frame_with_wait(): waits up to roughly one configured frame duration.advance_frame_with_wait_timeout(timeout): same behavior with an explicit timeout.These helpers reduce poll-phase stalls in lockstep mode without requiring users to hand-roll a busy-wait loop. In rollback mode, they behave like
advance_frame().