fix: support desync detection with sparse saves#115
Merged
Conversation
gschup
force-pushed
the
fix-desync-sparse-saving
branch
from
1954781 to
290d964
Compare
|
It is tough to say, something in the recent batch of commits makes the emulator freeze, so when I build from this branch, it also freezes. I'll try to bisect which commit started the problem. |
Owner
Author
|
My bad, as per usual I tried doing many things at once :D |
|
No worries, I release broken things all the time, this isn't even released. The issue starts for me with this change: #109 I see this in the logs over and over: |
|
I believe it is probably related to the input delay, which was set to 2 in this case |
gschup
force-pushed
the
fix-desync-sparse-saving
branch
from
290d964 to
a493778
Compare
Owner
Author
|
I tried a new LLM-based coding tool. Due to the new UI I missed a bug that was introduced. Whelp, it should be fixed now. Both on main and this PR. |
Regression test for the input_delay > 0 freeze: verifies that a first packet with start_frame=2 (as sent by a peer with input_delay=2) is accepted and decoded using the NULL_FRAME sentinel as reference. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
gschup
force-pushed
the
fix-desync-sparse-saving
branch
from
a493778 to
4faf71f
Compare
|
yes, seems all good now, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #107