Skip to content

fix(indicator): Indicator is not defined#51

Open
geminiyellow wants to merge 1 commit into
gs-akhan:masterfrom
geminiyellow:fix/indicator/undefined
Open

fix(indicator): Indicator is not defined#51
geminiyellow wants to merge 1 commit into
gs-akhan:masterfrom
geminiyellow:fix/indicator/undefined

Conversation

@geminiyellow

Copy link
Copy Markdown

sorry @gs-akhan , i use babel to import all the js file.
and you know,

Uncaught ReferenceError: Indicator is not defined
    at eval (webpack:///./src/Fuck.js?:1)
    at Object../src/Fuck.js (bundle.js:13126)
    at __webpack_require__ (bundle.js:710)
    at fn (bundle.js:95)
    at eval (webpack:///./src/App.js?:1)
    at Object../src/App.js (bundle.js:13114)
    at __webpack_require__ (bundle.js:710)
    at fn (bundle.js:95)
    at eval (webpack:///./index.web.js?:1)
    at Object../index.web.js (bundle.js:775)

i think your code is very good, but i think write it on more common format, the package is better.

@gs-akhan

Copy link
Copy Markdown
Owner

Hi, Should I merge this ?

Sorry for very very very long delay

@geminiyellow

Copy link
Copy Markdown
Author

@gs-akhan thank you ; )

@apolishch

Copy link
Copy Markdown

is this ever getting fixed/merged? Or is it fair to say that this project is dead?

@geminiyellow

Copy link
Copy Markdown
Author

@apolishch i dont know, if you dont comment on this PR, i already totally forgot it.
maybe you are right, no commit in 1 year means is dead.

@apolishch

Copy link
Copy Markdown

FWIW we forked it(and fixed this issue) here: https://github.com/flockcover/react-native-chooser
https://www.npmjs.com/package/@flockcover/react-native-chooser

If this project resumes life, we'll kill our fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants