feat(flight-visualizer): add basic flight visualizer - #83
Open
PatrykPaluch wants to merge 11 commits into
Open
Conversation
| } | ||
| } | ||
|
|
||
| pub struct OffsetVecIter<'a, T> |
Member
There was a problem hiding this comment.
just use a std::collections::VecDeque (pronounced deck)
if deque.len() == max_len {
deque.pop_front();
}
deque.push_back(value);you can wrap it in a CircularBuffer newtype if you want (and reuse VecDeque iterators), but it may be simpler if you simply don't.
Each time I inspected a collection data structure implemented at work I concluded that It was poorly designed and implemented, it introduced a ton of undocumented code that needed maintenance and we simply didn't need it at all. I'd strongly recommend avoiding writing them unless you know you really need them and you know what you are doing. It's really hardy to get those things right.
PatrykPaluch
marked this pull request as draft
August 27, 2023 01:42
PatrykPaluch
marked this pull request as ready for review
September 8, 2023 21:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
probably part of #74
Note:
lora-clineed to be compiled/run from pbak/lora-cli branch and it requires small changes in code - read flight-visualizer README.mdTODO: