⚡ Optimize get_messages polling performance

[bdqnghi]

💡 What:

• Removed multiple verbose print statements and json.dumps() serialization calls from within the for doc in query.stream(): iterator in the get_messages function.
• Upgraded the remaining ad-hoc logging statements in get_messages from generic print() to standard Python logger.debug(), logger.warning(), and logger.error().

🎯 Why:

• get_messages is the primary entrypoint for agents polling the server for new tasks. This endpoint executes repeatedly and rapidly.
• Writing to stdout via print requires locking and I/O context switching, acting as an unintended bottleneck within a for loop over documents.
• Furthermore, json.dumps() is CPU-bound, causing unnecessary overhead to serialize data purely for terminal logging purposes on every single poll.
• The use of logger over print prevents the server logs from becoming unmanageable under heavy polling scenarios, as debug output can be programmatically suppressed in production via the application's logging configuration.

📊 Measured Improvement:

• A benchmark script (tests/benchmark_perf.py) was implemented to test the cost of iterating over 10 documents via get_messages 1,000 times (simulating client polling).
• Baseline: 0.712 seconds
• Improvement: 0.476 seconds (with remaining prints converted to standard logging).
• The operation runs ~33% faster per cycle.

---

PR created automatically by Jules for task 13755499842599728994 started by @bdqnghi

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[entelligence-ai-pr-reviews]

EntelligenceAI PR Summary

Replaces print()-based logging with structured logger calls in get_messages() and adds a performance benchmark for the method.

• functions/mcp_network_server.py: Substituted all print() calls with logger.debug(), logger.warning(), and logger.error() in get_messages()
• functions/mcp_network_server.py: Removed per-message verbose output fields (type, task ID, acknowledgment status, timestamp, content, description, reply_to)
• tests/benchmark_perf.py: New benchmark script running get_messages() 1,000 iterations with mocked Firestore/Firebase, stdout suppressed during timed execution, reports result as 'Optimized Code'

---

Confidence Score: 5/5 - Safe to Merge

Safe to merge — this PR cleanly replaces print() calls with structured logger.debug(), logger.warning(), and logger.error() calls in get_messages() within mcp_network_server.py, which is a straightforward observability improvement with no logic changes. The removal of per-message verbose output fields (type, task ID, acknowledgment status, timestamp, content, description, reply_to) reduces noise in production logs without affecting any functional behavior. The addition of tests/benchmark_perf.py provides useful baseline performance coverage for the polling method. No issues were identified in either changed file.

Key Findings:

• The substitution of print() with structured logger calls in get_messages() is a safe, mechanical refactor — the logging levels chosen (debug for routine messages, warning/error for exceptional conditions) are appropriate and introduce no behavioral changes.
• Removal of verbose per-message output fields from the log statements is a deliberate reduction in log verbosity and does not affect any data processing, return values, or side effects of get_messages().
• The new tests/benchmark_perf.py benchmark script adds measurable coverage for the polling path and will help detect performance regressions in future changes to get_messages().

Files requiring special attention

• functions/mcp_network_server.py
• tests/benchmark_perf.py

[entelligence-ai-pr-reviews]

Walkthrough

This PR improves logging hygiene in the MCP network server by replacing raw print() statements with structured logger calls in get_messages(), and removes verbose per-message debug output. A companion benchmark script is added to measure get_messages() performance over 1,000 iterations using mocked Firebase/Firestore dependencies to establish a baseline for the optimized code.

Changes

File(s)	Summary
functions/mcp_network_server.py	Replaced all print() statements in get_messages() with structured logger calls (debug, warning, error); removed verbose per-message detail logging (type, task ID, acknowledgment status, timestamp, content, description, reply_to).
tests/benchmark_perf.py	Added new performance benchmark script measuring MessageQueue.get_messages() execution time over 1,000 iterations with mocked Firebase/Firestore dependencies, suppressing stdout during timed run and reporting elapsed time as 'Optimized Code'.

Sequence Diagram

This diagram shows the interactions between components:

sequenceDiagram
    participant Caller as "Agent / Caller"
    participant MQ as "MessageQueue"
    participant Logger as "Logger"
    participant FS as "Firestore"

    Caller->>MQ: get_messages(agent_id, last_message_id)
    activate MQ

    MQ->>Logger: debug("FETCHING MESSAGES FOR {agent_id}")
    MQ->>Logger: debug("Last message ID: {last_message_id}")

    MQ->>FS: messages_ref.document(agent_id).collection('queue')
    activate FS

    alt last_message_id provided
        MQ->>FS: get document(last_message_id)
        FS-->>MQ: last_message_doc

        alt document exists
            MQ->>FS: query.where('timestamp', '>', last_timestamp)
        else document not found / error
            MQ->>Logger: warning("Error getting last message: {e}")
        end
    end

    MQ->>FS: query.limit(10).stream()
    FS-->>MQ: message documents
    deactivate FS

    loop for each message doc
        MQ->>MQ: convert_timestamps_to_isoformat(msg_data)
        MQ->>MQ: append to messages list
    end

    MQ->>Logger: debug("Found {N} messages")

    MQ-->>Caller: messages[]
    deactivate MQ

Loading

---

🔗 Cross-Repository Impact Analysis

Enable automatic detection of breaking changes across your dependent repositories. → Set up now

Learn more about Cross-Repository Analysis

What It Does

• Automatically identifies repositories that depend on this code
• Analyzes potential breaking changes across your entire codebase
• Provides risk assessment before merging to prevent cross-repo issues

How to Enable

1. Visit Settings → Code Management
2. Configure repository dependencies
3. Future PRs will automatically include cross-repo impact analysis!

Benefits

• 🛡️ Prevent breaking changes across repositories
• 🔍 Catch integration issues before they reach production
• 📊 Better visibility into your multi-repo architecture

---