feat: updates for Nextcloud 34 - #102
Open
mwerle wants to merge 10 commits into
Open
Conversation
- replace obsolete APIs - update route definition - remove direct HTTP output and use Response API instead -
Also add stats. TODO: better theme display
Turns out that the Javscript to handle the unhiding of the settings has most likely been deprecated in new versions of Nextcloud which prevented it from working. Add our own Javascript click handler to re-enable the functionality. This allows us to get rid of all the other crud we had earlier. In future we should probably convert the app to Vue.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kind-of fixes #99 - while this version probably won't work with NC2x it does work with current version(s) of NC and an official release should allow installing from the App Store again.
Changes:
Testing:
Initial testing shows it "works for me" using Nextcloud 34, Android 16/Tomdroid v0.8.0, and Linux/Tomboy Reborn v1.0.0:
Untested: