Skip to content

Add Harker and TAS diagrams - #2

Merged
gronbow merged 2 commits into
mainfrom
feature/harker-tas-v0.3
Jul 30, 2026
Merged

Add Harker and TAS diagrams#2
gronbow merged 2 commits into
mainfrom
feature/harker-tas-v0.3

Conversation

@gronbow

@gronbow gronbow commented Jul 30, 2026

Copy link
Copy Markdown
Owner

Summary

  • add validated major-element input inspection for flat or unambiguous transposed CSV, TXT, and XLSX tables
  • add customizable multi-panel Harker diagrams with smart layout, group styling, clean axes, and publication export bundles
  • add guarded volcanic TAS classification using a versioned Le Maitre / Le Bas field asset and explicit boundary-review states
  • formalize GeoSkills v0.3.0 documentation, Codex installation guidance, release status, and changelog

The reviewed spider-diagram work from #1 is now part of main; this PR contains the remaining Harker, TAS, and v0.3.0 release changes.

Scientific safeguards

  • require explicit wt% or ppm units and preserve below-detection-limit values as missing
  • do not add default Harker regressions or infer petrogenetic processes; warn when specialist lithologies are mixed
  • require volcanic applicability confirmation and a declared composition basis before TAS classification
  • preserve ambiguous TAS fields, boundary points, and out-of-scope points as explicit review states
  • keep plotting deterministic and local; private inputs and generated outputs remain excluded from Git

Validation

  • pytest -q: 69 passed
  • quick_validate.py: Skill is valid
  • Python compilation and Git whitespace checks passed
  • Harker plotting tested with locally held published data; TAS tested with the committed synthetic fixture
  • export QA confirmed embedded PDF fonts, editable SVG text, 600 dpi PNG/TIFF, and LZW TIFF compression
  • Ubuntu and Windows CI passed on Python 3.11 and 3.12 after the final release update and base retarget

@gronbow
gronbow changed the base branch from feature/spider-diagram-v0.2 to main July 30, 2026 10:39
@gronbow
gronbow marked this pull request as ready for review July 30, 2026 10:47
@gronbow
gronbow merged commit 1fc6ede into main Jul 30, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant