Fix evaluation script on invalid arguments instead of exiting 0#1515
Merged
Conversation
EndToEndEvaluation.main() validated its arguments and then returned, so the JVM exited 0. Gradle reported BUILD SUCCESSFUL, run_evaluation.sh saw a successful build, and the only symptom was the missing markdown report - reported as "report not found after successful build", which points at the report rather than at the argument that was rejected. Reproduced with `-PfileRatio=article/light-ref`: "Invalid argument fileRatio, must be a double" on stderr, BUILD SUCCESSFUL, exit 0. Every validation bail-out in main() now exits 1, so the failure surfaces where it happens. Two related traps, same shape: - An unrecognised flavor fell back to the default process with only an informational message, so the evaluation silently measured something other than what was asked for and the report gave no hint. A non-empty flavor that does not resolve is now an error listing the known flavors. An absent or empty flavor still means the default. - run_evaluation.sh's -f is the file ratio; the flavor is -l. Passing a flavor to -f was accepted and only failed much later. -f is now validated, and a value containing '/' suggests -l instead.
Signed-off-by: Luca Foppiano <luca@foppiano.org>
lfoppiano
force-pushed
the
fix/eval-invalid-args-exit-code
branch
from
July 21, 2026 21:42
55a54e3 to
1797200
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EndToEndEvaluation.main() validated its arguments and then returned, so the JVM exited 0. Gradle reported BUILD SUCCESSFUL, run_evaluation.sh saw a successful build, and the only symptom was the missing markdown report - reported as "report not found after successful build", which points at the report rather than at the argument that was rejected.
Reproduced with
-PfileRatio=article/light-ref: "Invalid argument fileRatio, must be a double" on stderr, BUILD SUCCESSFUL, exit 0.Every validation bail-out in main() now exits 1, so the failure surfaces where it happens.
Two related traps, same shape:
An unrecognised flavor fell back to the default process with only an informational message, so the evaluation silently measured something other than what was asked for and the report gave no hint. A non-empty flavor that does not resolve is now an error listing the known flavors. An absent or empty flavor still means the default.
run_evaluation.sh's -f is the file ratio; the flavor is -l. Passing a flavor to -f was accepted and only failed much later. -f is now validated, and a value containing '/' suggests -l instead.