Skip to content

Support for documents in humanities, Law, and pre-1900 layouts (footnotes-driven)#1325

Draft
lfoppiano wants to merge 56 commits into
masterfrom
feature/literature-law-flavour
Draft

Support for documents in humanities, Law, and pre-1900 layouts (footnotes-driven)#1325
lfoppiano wants to merge 56 commits into
masterfrom
feature/literature-law-flavour

Conversation

@lfoppiano

@lfoppiano lfoppiano commented Aug 6, 2025

Copy link
Copy Markdown
Member

This flavor aims to develop a special flavour for Law and certain Humanities articles using footnotes for reference/footnotes/mixed content.

Guidelines are here: https://github.com/cboulanger/grobid-footnote-flavour/blob/main/docs/guidelines.md

@coveralls

coveralls commented Aug 6, 2025

Copy link
Copy Markdown

Coverage Status

coverage: 40.466% (+0.2%) from 40.279%
when pulling 7d7e0b6 on feature/literature-law-flavour
into 1ad5901 on master.

@lfoppiano lfoppiano changed the title DH and LAW Literature flavour Foonote-references flavour Nov 11, 2025
@lfoppiano
lfoppiano force-pushed the feature/literature-law-flavour branch from 7d7e0b6 to a13f0d5 Compare January 30, 2026 16:14
@coveralls

coveralls commented Jan 30, 2026

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 21991403140

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 109 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.01%) to 38.258%

Files with Coverage Reduction New Missed Lines %
org/grobid/core/utilities/Utilities.java 1 26.63%
org/grobid/core/GrobidModels.java 8 85.82%
org/grobid/core/engines/ReferenceSegmenterParser.java 38 49.77%
org/grobid/trainer/sax/TEISegmentationSaxParser.java 62 3.74%
Totals Coverage Status
Change from base Build 21969397686: -0.01%
Covered Lines: 17266
Relevant Lines: 42518

💛 - Coveralls

@lfoppiano
lfoppiano force-pushed the feature/literature-law-flavour branch from 65cfb01 to 7272991 Compare February 13, 2026 13:19
@lfoppiano
lfoppiano force-pushed the feature/literature-law-flavour branch from 825e438 to 03a79f3 Compare April 2, 2026 09:51
@lfoppiano
lfoppiano force-pushed the feature/literature-law-flavour branch from 0eac3b9 to fa98d42 Compare May 9, 2026 16:21
Comment thread grobid-trainer/scripts/sync_lb_positions.py Fixed
@lfoppiano lfoppiano changed the title Foonote-references flavour Support for documents in humanities, Law, and pre-1900 layouts (footnotes-driven) Jul 19, 2026
@lfoppiano lfoppiano linked an issue Jul 20, 2026 that may be closed by this pull request
lfoppiano added 26 commits July 21, 2026 17:11
Signed-off-by: Luca Foppiano <luca@foppiano.org>
Signed-off-by: Luca Foppiano <luca@foppiano.org>
Signed-off-by: Luca Foppiano <luca@foppiano.org>
Signed-off-by: Luca Foppiano <luca@foppiano.org>
Signed-off-by: Luca Foppiano <luca@foppiano.org>
Two conflicts git auto-merged into non-compiling code:

- AbstractParser declared `model` twice. Master added the field for the
  debug labelling API (#1439), this branch added it for flavor-aware
  engine resolution. Kept one field with the flavor rationale.

- Engine.createTrainingBlank passed `id` to createBlankTrainingData for
  the flavor overload. #1508 dropped that parameter - the xml:id is now
  derived from the input file name - so the call now matches the
  non-flavor overload above it.
@lfoppiano
lfoppiano force-pushed the feature/literature-law-flavour branch from d246509 to 4417299 Compare July 21, 2026 15:40
continue

for check_num, check_fn in [
(2, lambda elem: check_valid_labels(elem)),

for check_num, check_fn in [
(2, lambda elem: check_valid_labels(elem)),
(3, lambda elem: check_untagged_text(elem)),
for check_num, check_fn in [
(2, lambda elem: check_valid_labels(elem)),
(3, lambda elem: check_untagged_text(elem)),
(4, lambda elem: check_empty_labels(elem)),
Signed-off-by: Luca Foppiano <luca@foppiano.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Training grobid to spot ancient references

3 participants