Skip to content

Stream PDF from archives #117

Open
lfoppiano wants to merge 2 commits into
masterfrom
feature/stream-archive-input
Open

Stream PDF from archives #117
lfoppiano wants to merge 2 commits into
masterfrom
feature/stream-archive-input

Conversation

@lfoppiano

Copy link
Copy Markdown
Member

TBA

Add process_archive(), used automatically when --input points to a
.zip/.tar/.tar.gz (.tgz/.tar.bz2/.tbz2) archive. Eligible entries are read out
of the archive in chunks of batch_size, each chunk is extracted to a temporary
directory, sent to GROBID via the existing process_batch (so concurrency,
TEI/JSON/Markdown output, --force/skip and error handling are reused), and the
temporary files are removed before the next chunk is extracted. The archive is
never fully decompressed, so disk usage stays bounded regardless of its size.

- zip via zipfile, tar/tar.gz/tar.bz2 via tarfile ('r:*')
- entries are streamed member-by-member (zipfile.open / tarfile.extractfile)
- archive paths are sanitized to prevent path traversal (zip slip)
- when --output is omitted, results go to a directory named after the archive
- directory-input eligibility check refactored into _is_eligible_input and shared

Documented in the Readme and covered by unit tests (zip, tar.gz, chunking,
cleanup, default output, traversal guard, delegation).
…rsal

--input now accepts shell-style glob patterns (with recursive **), e.g.
'paper.zip' (one file), 'paper*.zip' (many), '**/paper*.zip' (subdirectories)
or '**/*.pdf'. Each match is dispatched by type: archives are streamed,
directories are recursed, eligible files are processed directly, and the
results of all matches are aggregated into a single summary.

- resolve --input via glob (has_magic + recursive=True, ~ expansion); a plain
  path is returned unchanged for backward compatibility
- directory traversal refactored from os.walk to pathlib.Path.rglob
- factor the batching loop, stats summary and archive streaming into reusable
  helpers (_run_file_batches, _print_processing_summary, _process_archive_core)
  so directory, loose-file and archive inputs share one code path
- loose files matched by a glob are batched together under their common base

Documented in the Readme and covered by unit tests (multi-archive glob,
recursive **/*.pdf, mixed matches, no-match warning, common-base helper).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant