Skip to content

Added support for no-padded day of month (%-d)#11

Open
piotrekbator wants to merge 2 commits into
grk:masterfrom
nibynic:master
Open

Added support for no-padded day of month (%-d)#11
piotrekbator wants to merge 2 commits into
grk:masterfrom
nibynic:master

Conversation

@piotrekbator

Copy link
Copy Markdown

Up to now month names were inflected only when used after %d (0-padded) or %e (blank-padded). This adds no-padded version - %-d to the list.

@grk

grk commented Feb 6, 2020

Copy link
Copy Markdown
Owner

Is this gem necessary anymore? I think rails-i18n should cover this.

@piotrekbator

Copy link
Copy Markdown
Author

Rails-i18n doesn't inflect month names - at least I'm unable to find any trace of it being able to do it. Am I wrong?

Besides, your gem works perfectly well, I've used it for years, so why bother looking for alternatives :)

@grk

grk commented Feb 6, 2020

Copy link
Copy Markdown
Owner

@piotrekbator could you check out the modernize branch? It should have tests passing on a modern ruby version, and hopefully work OK in a Rails app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants