Skip to content

Pulling from upstream - #1

Draft
griels wants to merge 10000 commits into
griels:masterfrom
Homebrew:master
Draft

Pulling from upstream#1
griels wants to merge 10000 commits into
griels:masterfrom
Homebrew:master

Conversation

@griels

@griels griels commented May 5, 2022

Copy link
Copy Markdown
Owner

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

Additionally, if updating a cask:

  • sha256 changed but version stayed the same (what is this?).
    I’m providing public confirmation below.

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.
  • Checked there are no open pull requests for the same cask.
  • Checked the cask was not already refused in closed issues.
  • Checked the cask is submitted to the correct repo.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants