Use "text-overflow:ellipsis" to prevent overflow in header - #41
Open
dholbert wants to merge 1 commit into
Open
Conversation
…ing out of the header and making app wider than the screen.
Author
|
BUG SCREENSHOTS: ...and you can actually "pan" to see the rest of it (and break the UI), as shown here: Here's what this looks like after the patch is applied, though (fixing the issue): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you open a folder with a really long name, then the folder-name displayed in the header will overflow off the screen, and make the app wider from the screen. (which makes it "pannable" in a way that looks broken).
Patch attached to fix this, by giving this header "text-overflow: ellipsis" (and overflow:hidden, which is required for "text-overflow" to work).