feat: switch repos using GitHub Pages to workflow based deploys - #388
Conversation
Signed-off-by: James Ramirez <james.ramirez@grendel-consulting.com>
WalkthroughThe change updates the Changes
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
No security concerns detected in this pull request. All finding details can be found in the DryRun Security Dashboard. |
Terraform Cloud Plan OutputPlan: 0 to add, 2 to change, 2 to destroy. |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
modules/repository/repository.tf (1)
65-69: Consider removing manual creation of thegh-pagesbranchWhen
build_type = "workflow"GitHub Actions will create (and recreate) thegh-pagesbranch automatically during the deploy-pages workflow.
Keeping the explicitgithub_branch.pagesresource introduces an extra empty commit and an unnecessary dependency unless you need pre-protection or seeded content.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
modules/repository/repository.tf(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: terraform-cloud-speculative-run
🔇 Additional comments (1)
modules/repository/repository.tf (1)
29-37: Confirmed GitHub provider supportsbuild_type = "workflowThe project is pinned to version 6.6.0 of the
integrations/githubprovider (in bothversions.tfandmodules/repository/providers.tf), and sincebuild_type = "workflow"was introduced in v5.38, this setting is fully supported—no change needed.
Signed-off-by: James Ramirez <james.ramirez@grendel-consulting.com>
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|



Summary by CodeRabbit