Skip to content

feat: switch repos using GitHub Pages to workflow based deploys - #388

Merged
ramirezj merged 2 commits into
mainfrom
github_pages
Jul 18, 2025
Merged

feat: switch repos using GitHub Pages to workflow based deploys#388
ramirezj merged 2 commits into
mainfrom
github_pages

Conversation

@ramirezj

@ramirezj ramirezj commented Jul 18, 2025

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Updated the GitHub Pages build configuration for the repository.

Signed-off-by: James Ramirez <james.ramirez@grendel-consulting.com>
@coderabbitai

coderabbitai Bot commented Jul 18, 2025

Copy link
Copy Markdown

Walkthrough

The change updates the pages dynamic block within the github_repository resource by changing the build_type from "legacy" to "workflow" and removes the nested source block specifying the branch "gh-pages". It also removes the separate conditional github_branch resource for the "gh-pages" branch. No other logic or exported entities are affected.

Changes

File(s) Change Summary
modules/repository/repository.tf Updated build_type in pages block from "legacy" to "workflow", removed source block, and deleted conditional github_branch resource for "gh-pages" branch

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 201a3c1 and 4fdcae2.

📒 Files selected for processing (1)
  • modules/repository/repository.tf (1 hunks)
🔇 Additional comments (1)
modules/repository/repository.tf (1)

29-34: Verify presence of GitHub Actions Pages workflow

I ran a search for workflow files referencing “pages” under .github/workflows and found none. Please ensure every repository using this module includes a GitHub Actions workflow to deploy Pages (for example, .github/workflows/pages.yml), otherwise Pages will remain disabled.

• Confirm there is a workflow file targeting the pages deployment (e.g. .github/workflows/pages.yml).

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch github_pages

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dryrunsecurity

Copy link
Copy Markdown

DryRun Security

No security concerns detected in this pull request.


All finding details can be found in the DryRun Security Dashboard.

@github-actions

github-actions Bot commented Jul 18, 2025

Copy link
Copy Markdown

Terraform Cloud Plan Output

Plan: 0 to add, 2 to change, 2 to destroy.
Terraform Cloud Plan

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
modules/repository/repository.tf (1)

65-69: Consider removing manual creation of the gh-pages branch

When build_type = "workflow" GitHub Actions will create (and recreate) the gh-pages branch automatically during the deploy-pages workflow.
Keeping the explicit github_branch.pages resource introduces an extra empty commit and an unnecessary dependency unless you need pre-protection or seeded content.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3756f36 and 201a3c1.

📒 Files selected for processing (1)
  • modules/repository/repository.tf (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: terraform-cloud-speculative-run
🔇 Additional comments (1)
modules/repository/repository.tf (1)

29-37: Confirmed GitHub provider supports build_type = "workflow

The project is pinned to version 6.6.0 of the integrations/github provider (in both versions.tf and modules/repository/providers.tf), and since build_type = "workflow" was introduced in v5.38, this setting is fully supported—no change needed.

Signed-off-by: James Ramirez <james.ramirez@grendel-consulting.com>
@sonarqubecloud

Copy link
Copy Markdown

@ramirezj

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 18, 2025

Copy link
Copy Markdown
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@ramirezj
ramirezj merged commit 62639af into main Jul 18, 2025
17 checks passed
@ramirezj
ramirezj deleted the github_pages branch July 18, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant