Skip to content

Sync workspace version with v1.0.0 release tag - #5

Merged
gregnazario merged 1 commit into
mainfrom
best-practices/sync-version
Aug 31, 2026
Merged

gregnazario merged 1 commit into
mainfrom
best-practices/sync-version

Conversation

@gregnazario

Copy link
Copy Markdown
Owner

The workspace version was still 0.1.0 while the only release tag is v1.0.0, so released binaries self-reported 0.1.0. Bumps the workspace version to 1.0.0 and regenerates Cargo.lock accordingly (member crates use version.workspace = true inheritance, so no other manifest changes were needed).

@hedgehog-pr-bot hedgehog-pr-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pi code review

No new findings.

This PR is a minimal, consistent version bump: workspace.package.version in Cargo.toml goes from 0.1.0 to 1.0.0, and the Cargo.lock entries for every must-* workspace member shown in the diff (28 packages, from must-bridge through must-toolchain) are updated to match. I checked for: leftover 0.1.0 entries in the lockfile diff (none), mismatched versions between the workspace manifest and lock (none), missing member bumps in the visible hunks (none — the gaps between hunks correspond to dependency lists, not unversioned packages), and whether anything else in the diff would need to change alongside the bump (nothing). No actionable issues found. Two non-blocking notes outside the diff: (1) the existing v1.0.0 tag points at a commit that built 0.1.0, so after merging it's better to cut v1.0.1 than to retag; (2) if any member manifests pin internal path dependencies with a version = "0.1" requirement, cargo would reject 1.0.0 — worth confirming CI ran a full build, though the successfully regenerated lockfile suggests inheritance is used as described.


Reviewed 28b7440 with Pi 0.84.2 using zai/glm-5.3:high.

@codecov

codecov Bot commented Aug 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.01%. Comparing base (1b40733) to head (28b7440).

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #5   +/-   ##
=======================================
  Coverage   92.01%   92.01%           
=======================================
  Files          49       49           
  Lines       18129    18129           
=======================================
  Hits        16681    16681           
  Misses       1448     1448           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gregnazario
gregnazario merged commit 560a849 into main Aug 31, 2026
8 checks passed
@gregnazario
gregnazario deleted the best-practices/sync-version branch August 31, 2026 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant