Repository navigation
chore: add Apache-2.0 license - #4
Conversation
Pi code reviewFindingsHigh — Unilateral license change from MIT to Apache-2.0, mislabeled as a chore
The PR title says Impact:
Fix: Do not merge as a chore. Confirm the relicensing intent is deliberate and documented; verify the code is solely owned by the author or obtain agreement from all contributors. Also correct the PR description — the base branch demonstrably contains an MIT LICENSE per this diff. Medium — Inconsistent copyright attribution and duplicated appendix boilerplate
The file retains the unfilled template
Fix: Once rights are sorted, keep a single applied notice with the correct holder (e.g., Low — Leading blank line breaks byte-for-byte match with canonical Apache-2.0 text
The file starts with an empty line before the Fix: Remove the leading blank line so the file matches the canonical text exactly. (I compared the body text against the canonical license and it is otherwise faithful — no altered clauses found.) Low — Cross-PR ordering leaves README self-inconsistent
The badge flip to match is deferred to PR #2. If this PR merges first, the README will state Apache-2.0 in the License section while its badge still says MIT. Similarly, any SPDX Fix: Either land the badge change in this PR or explicitly sequence #2 before this one, and update any Reviewed 2704085 with Pi 0.84.2 using zai/glm-5.3:high. |
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4 +/- ##
=======================================
Coverage 92.01% 92.01%
=======================================
Files 49 49
Lines 18129 18129
=======================================
Hits 16681 16681
Misses 1448 1448 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The repo had no LICENSE file at all while the README's License section claimed MIT with a dangling link (flagged via the #2 review chain). Adds the canonical Apache-2.0 text in worktree-ui house format and corrects the section. Badge flip for the readme-polish branch rides in #2.