refactor(shared,client): restore capability ownership and reuse - #802
Open
Oba-One wants to merge 4 commits into
Open
refactor(shared,client): restore capability ownership and reuse#802Oba-One wants to merge 4 commits into
Oba-One wants to merge 4 commits into
Conversation
Refresh evidence left stale by the parent Celo changes after rerunning all 12 recorded proof files: 205 tests passed and 4 existing cases skipped. Preserve the registered boundaries and review dates.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (70)
💤 Files with no reviewable changes (6)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details🧰 Additional context used📓 Path-based instructions (12)Read it first, then the nearest package `AGENTS.md`.📄 CodeRabbit inference engine (CLAUDE.md) Files:
Add every new user-facing string to `src/i18n/en.json`, `src/i18n/es.json`, and `src/i18n/pt.json`.📄 CodeRabbit inference engine (packages/shared/AGENTS.md) Files:
Use this guide when editing `packages/client/**`.📄 CodeRabbit inference engine (packages/client/AGENTS.md) Files:
Use this guide when editing `packages/shared/**`.📄 CodeRabbit inference engine (packages/shared/AGENTS.md) Files:
Use `bun run test`, never `bun test`📄 CodeRabbit inference engine (.github/copilot-instructions.md) Files:
Add every new user-facing string to `en`, `es`, and `pt` language files📄 CodeRabbit inference engine (.github/copilot-instructions.md) Files:
Keep `AGENTS.md`, `CLAUDE.md`, `.codex/**`, and `.claude/**` human-governed even when Copilot review runs automatically📄 CodeRabbit inference engine (.github/copilot-instructions.md) Files:
Keep reusable hooks, providers, stores, modules, and shared UI primitives in `@green-goods/shared`📄 CodeRabbit inference engine (.github/copilot-instructions.md) Files:
Use `bun run test` for running tests📄 CodeRabbit inference engine (.github/copilot-instructions.md) Files:
Default to single-chain behavior through `getDefaultChain()` or `DEFAULT_CHAIN_ID` Use `logger` from shared instead of `console.log` Use `bun run format:check && bun lint` for code quality checks📄 CodeRabbit inference engine (.github/copilot-instructions.md) Files:
Use Remixicon (`Ri*Line`), never lucide for UI icons📄 CodeRabbit inference engine (.github/copilot-instructions.md) Files:
Use the `Address` type for Ethereum addresses instead of raw string types📄 CodeRabbit inference engine (.github/copilot-instructions.md) Files:
🔇 Additional comments (54)
📝 SummarySummary by CodeRabbit
WalkthroughThe PR centralizes online status, account signing, wizard transitions, treasury amount handling, and capability-boundary enforcement. It also updates architecture guidance, generated documentation, translations, tests, and seam fingerprints. ChangesShared capability consolidation
Estimated code review effort: 4 (Complex) | ~45 minutes Merge Risk: ⚪ Minimal · up to This refactor centralizes shared signing, navigation, connectivity, and treasury input behavior while retaining the tested flow contracts. No merge-blocking risk remains. Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 14.81% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 27 functions across 50 files. (14 skipped: 11 unsupported, 3 over the file limit.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| @@ -1,3 +1,4 @@ | |||
| vi.mock("@green-goods/shared/hooks/app/useOnlineStatus", () => ({ useOnlineStatus: () => true })); | |||
Oba-One
marked this pull request as ready for review
September 6, 2026 09:11
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #799, targeting
feature/gardener-celo-wallets. This PR contains the three cleanup commits and one generated-documentation refresh after the Celo checkpoint: 70 files, 787 additions and 399 deletions; production code is 85 lines smaller. It adds no UI components or dependencies and leaves sponsorship configuration unchanged.Validation
15e7970b0..01d490903: no must-fix or should-fix findings.bun run docs:generate; generator tests and documentation authority checks passed.c825265a9: format, lint, package typechecks/tests/builds, contract release verification, documentation, and architecture/design/guidance guards.The source-structure guard retains seven existing baseline violations. Static dependency checks do not certify module depth or runtime behavior; those remain review responsibilities.