Fix tsh/common test timeout by sharing kube cluster fixtures - #69625
Draft
jakealti wants to merge 6 commits into
Draft
Fix tsh/common test timeout by sharing kube cluster fixtures#69625jakealti wants to merge 6 commits into
jakealti wants to merge 6 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests in
tool/tsh/commonwere timing out in CI.When a test changes, CI runs it 100 times to check for flakiness.
That job has a 10 minute limit.
TestKubeandTestKubeLoginstart three Teleport clusters between them,and they did it on every one of the 100 runs.
So once a test with this setup was added, the job ran out of time.
Now the clusters are started once and reused.
There are two of them, one for each proxy mode the tests cover.
TestKube+TestKubeLoginon my machine, with the same flags CI uses(
-race -shuffle on):-count 1-count 10Before, each extra run added about 13 seconds. Now it adds less than 1.
That takes 100 runs from roughly 20 minutes down to under 2.
Only tests changed. No change in behavior.