Skip to content

fix(geojson): correct array precedence in the generated codegen type #3089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ifeanyi-ugwu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(geojson): correct array precedence in the generated codegen type #3089

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/scalars/GeoJSON/codegenScalarType.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
// Helper function to generate Position type
const generatePositionType = () => `[number, number] | [number, number, number]`;
// Helper function to generate Position type.
// Parenthesized so that array usages (`${generatePositionType()}[]`) apply `[]`
// to the whole union rather than only the second member.
const generatePositionType = () => `([number, number] | [number, number, number])`;

// Helper function to generate BBox type
const generateBBoxType = () =>
Expand Down