fix(scalars): parse USCurrency amounts with multiple thousands separators#3087
Open
ifeanyi-ugwu wants to merge 1 commit into
Open
fix(scalars): parse USCurrency amounts with multiple thousands separators#3087ifeanyi-ugwu wants to merge 1 commit into
ifeanyi-ugwu wants to merge 1 commit into
Conversation
…tors generateCents stripped only the first comma, so a value like $1,000,000.00 parsed as $1,000.00 — parseFloat stopped at the second separator and dropped the rest. It now removes every separator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generateCentsstripped only the first thousands separator (.replace(',', '')), so an amount with more than one separator parsed to the wrong value — e.g.$1,000,000.00parsed as$1,000.00, becauseparseFloatstops at the second comma. It now removes every separator (.replace(/,/g, '')).Adds a regression test (
$1,000,000.00→100000000cents) that fails without the fix. The existing tests only used single-separator amounts ($22,900.00), which the one-comma replace happened to handle.