fix(scalars): add missing @specifiedBy URL to the HSLA scalar#3080
Open
greymoth-jp wants to merge 1 commit into
Open
fix(scalars): add missing @specifiedBy URL to the HSLA scalar#3080greymoth-jp wants to merge 1 commit into
greymoth-jp wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
HSLscalar setsspecifiedByURL(plus the lowercasespecifiedByUrlalias that graphql v15 reads), so its printed type isscalar HSL @specifiedBy(url: "..."). Its siblingHSLAwas missing both keys, so it prints a barescalar HSLAwith no@specifiedBydirective, even though the MDN page they share (#hsl()_and_hsla()) covers both functions.This just copies the same URL onto
HSLAso the pair stays in sync. Output withgraphql16:I added a test asserting
GraphQLHSLA.specifiedByURLmatches HSL's. Onmasterit fails withReceived: undefined; with the changejest tests/HSLA.test.ts tests/HSL.test.tsis green (13 passing) and prettier is clean. Changeset included as a patch.