ci: run the gfql lanes on chain-engine changes - #2057
Closed
lmeyerov wants to merge 1 commit into
Closed
Conversation
The gfql change filter listed compute/gfql/** and the unified entrypoint but not the chain engine itself (chain.py, chain_fast_paths.py, hop.py, gfql_fast_paths.py, filter_by_dict.py, ast.py, predicates/), so a PR touching only those skipped tck-gfql, the Cypher-frontend gates and the gfql benchmark lane. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QztW7jYsDd66e8rb8pJNQA
Contributor
Author
|
Folded into #2054 (owner asked for a shallower stack); the commits, receipts and CHANGELOG entries live there unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft for the owner's call (raised in the #2055 review).
The gfql change filter covered
compute/gfql/**,gfql_unified.py,gfql_validate.pyand the gfql test trees, but not the chain engine:compute/chain.py,chain_fast_paths.py,hop.py,gfql_fast_paths.py,filter_by_dict.py,ast.py,predicates/. #2055 (achain.pyfix) therefore ran with tck-gfql, the four Cypher-frontend gates and the gfql benchmark lane skipped, even after a rebase onto master.This adds those product files and the
test_chain*.py/test_hop*.pytest files to the filter. Cost: those lanes now run on chain-engine PRs (tck-gfql is ~15 min).🤖 Generated with Claude Code
https://claude.ai/code/session_01QztW7jYsDd66e8rb8pJNQA