Skip to content

ci: gate downstream test silos explicitly #1694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lmeyerov merged 2 commits into from
Jul 6, 2026
Merged

ci: gate downstream test silos explicitly #1694

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59c6258
ci: gate downstream test silos explicitly
lmeyerov Jul 5, 2026
80547fa
ci: preserve docs fallback in downstream gates
lmeyerov Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 35 additions & 22 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ jobs:
HEAD_SHA: ${{ github.sha }}
run: |
set -euo pipefail
keys=(infra python spark gfql cypher_frontend_ci benchmarks ai docs core plugins networkx docs_test schema_lane pandas_compat graphviz_lane neo4j_lane build_package dgl_lane networkx_test_only docs_test_only benchmarks_only narrow_python_only)
keys=(infra python spark gfql cypher_frontend_ci benchmarks ai docs core plugins networkx docs_test schema_lane pandas_compat graphviz_lane neo4j_lane build_package dgl_lane networkx_test_only docs_test_only benchmarks_only graphviz_only neo4j_only build_package_only narrow_python_only)

emit_all() {
# $1 = "true" or "false" — emit the same value for every key
Expand Down Expand Up @@ -393,8 +393,25 @@ jobs:
'^CHANGELOG\.md$' \
'^benchmarks/'

emit_only graphviz_only \
'^CHANGELOG\.md$' \
'^graphistry/plotter\.py$' \
'^graphistry/tests/.*graphviz.*\.py$' \
'^bin/test-graphviz\.sh$' \
'^requirements/test-graphviz-py.*\.lock$'

emit_only neo4j_only \
'^CHANGELOG\.md$' \
'^docker/.*neo4j' \
'^graphistry/bolt_util\.py$' \
'^graphistry/tests/test_bolt_util\.py$'

emit_only build_package_only \
'^CHANGELOG\.md$' \
'^graphistry/py\.typed$'

narrow_python_only="false"
if [[ "${networkx_test_only}" == "true" || "${docs_test_only}" == "true" || "${benchmarks_only}" == "true" ]]; then
if [[ "${networkx_test_only}" == "true" || "${docs_test_only}" == "true" || "${benchmarks_only}" == "true" || "${graphviz_only}" == "true" || "${neo4j_only}" == "true" || "${build_package_only}" == "true" ]]; then
narrow_python_only="true"
fi
echo "narrow_python_only=${narrow_python_only}" >> "$GITHUB_OUTPUT"
Expand Down Expand Up @@ -531,7 +548,7 @@ jobs:

check-rtd-lockfile:
needs: changes
if: ${{ (needs.changes.outputs.docs == 'true' && needs.changes.outputs.networkx_test_only != 'true' && needs.changes.outputs.benchmarks_only != 'true') || needs.changes.outputs.docs_test == 'true' || needs.changes.outputs.infra == 'true' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule' }}
if: ${{ (needs.changes.outputs.docs == 'true' && needs.changes.outputs.networkx_test_only != 'true' && needs.changes.outputs.benchmarks_only != 'true') || (needs.changes.outputs.python == 'true' && needs.changes.outputs.narrow_python_only != 'true') || needs.changes.outputs.docs_test == 'true' || needs.changes.outputs.infra == 'true' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule' }}
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
Expand Down Expand Up @@ -1026,9 +1043,9 @@ jobs:


test-minimal-python-rest:
# Middle versions (3.9-3.13) + non-GFQL deferred files, run after sentinel + GFQL core pass.
needs: [changes, test-minimal-python, test-gfql-core, generate-lockfiles]
if: ${{ success() }}
# Middle versions (3.9-3.13) + non-GFQL deferred files.
needs: [changes, test-minimal-python, generate-lockfiles]
if: ${{ ((needs.changes.outputs.python == 'true' && needs.changes.outputs.narrow_python_only != 'true') || needs.changes.outputs.core == 'true' || needs.changes.outputs.infra == 'true' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule') && !(needs.changes.outputs.docs_only_latest == 'true' && (github.event_name == 'push' || github.event_name == 'pull_request')) }}
runs-on: ubuntu-latest
timeout-minutes: 15

Expand Down Expand Up @@ -1404,9 +1421,8 @@ jobs:


test-core-python:
needs: [ test-minimal-python, test-gfql-core, generate-lockfiles ]
# Inherit condition from test-minimal-python
if: ${{ success() }}
needs: [changes, test-minimal-python, generate-lockfiles]
if: ${{ ((needs.changes.outputs.python == 'true' && needs.changes.outputs.narrow_python_only != 'true') || needs.changes.outputs.core == 'true' || needs.changes.outputs.infra == 'true' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule') && !(needs.changes.outputs.docs_only_latest == 'true' && (github.event_name == 'push' || github.event_name == 'pull_request')) }}
runs-on: ubuntu-latest
timeout-minutes: 8

Expand Down Expand Up @@ -1465,9 +1481,8 @@ jobs:
retention-days: 14

test-graphviz:
needs: [ test-minimal-python, test-gfql-core, generate-lockfiles ]
# Inherit condition from test-minimal-python
if: ${{ success() }}
needs: [changes, test-minimal-python, generate-lockfiles]
if: ${{ ((needs.changes.outputs.python == 'true' && needs.changes.outputs.narrow_python_only != 'true') || needs.changes.outputs.graphviz_lane == 'true' || needs.changes.outputs.core == 'true' || needs.changes.outputs.infra == 'true' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule') && !(needs.changes.outputs.docs_only_latest == 'true' && (github.event_name == 'push' || github.event_name == 'pull_request')) }}
runs-on: ubuntu-latest
timeout-minutes: 10 # Accommodate retry logic: 3 attempts × 2min + 1.5min backoff/cleanup

Expand Down Expand Up @@ -1532,8 +1547,8 @@ jobs:
./bin/test-graphviz.sh

test-polars:
needs: [ test-minimal-python, test-gfql-core, generate-lockfiles ]
if: ${{ success() }}
needs: [changes, test-minimal-python, test-gfql-core, generate-lockfiles]
if: ${{ ((needs.changes.outputs.python == 'true' && needs.changes.outputs.narrow_python_only != 'true') || needs.changes.outputs.gfql == 'true' || needs.changes.outputs.pandas_compat == 'true' || needs.changes.outputs.core == 'true' || needs.changes.outputs.infra == 'true' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule') && !(needs.changes.outputs.docs_only_latest == 'true' && (github.event_name == 'push' || github.event_name == 'pull_request')) }}
runs-on: ubuntu-latest
timeout-minutes: 10

Expand Down Expand Up @@ -1908,9 +1923,8 @@ jobs:


test-neo4j:
needs: [ test-minimal-python, test-gfql-core ]
# Inherit condition from test-minimal-python
if: ${{ success() }}
needs: [changes, test-minimal-python]
if: ${{ ((needs.changes.outputs.python == 'true' && needs.changes.outputs.narrow_python_only != 'true') || needs.changes.outputs.neo4j_lane == 'true' || needs.changes.outputs.core == 'true' || needs.changes.outputs.infra == 'true' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule') && !(needs.changes.outputs.docs_only_latest == 'true' && (github.event_name == 'push' || github.event_name == 'pull_request')) }}
runs-on: ubuntu-latest
timeout-minutes: 3
env:
Expand All @@ -1930,9 +1944,8 @@ jobs:


test-build:
needs: [ test-minimal-python, test-gfql-core, generate-lockfiles ]
# Inherit condition from test-minimal-python
if: ${{ success() }}
needs: [changes, test-minimal-python, generate-lockfiles]
if: ${{ ((needs.changes.outputs.python == 'true' && needs.changes.outputs.narrow_python_only != 'true') || needs.changes.outputs.build_package == 'true' || needs.changes.outputs.core == 'true' || needs.changes.outputs.infra == 'true' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule') && !(needs.changes.outputs.docs_only_latest == 'true' && (github.event_name == 'push' || github.event_name == 'pull_request')) }}
runs-on: ubuntu-latest
timeout-minutes: 2

Expand Down Expand Up @@ -1973,7 +1986,7 @@ jobs:
docs-latex-unicode-guard:
needs: [changes]
# Run if docs changed OR Python changed OR infrastructure changed OR manual/scheduled run
if: ${{ (needs.changes.outputs.docs == 'true' && needs.changes.outputs.networkx_test_only != 'true' && needs.changes.outputs.benchmarks_only != 'true') || needs.changes.outputs.docs_test == 'true' || needs.changes.outputs.infra == 'true' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule' }}
if: ${{ (needs.changes.outputs.docs == 'true' && needs.changes.outputs.networkx_test_only != 'true' && needs.changes.outputs.benchmarks_only != 'true') || (needs.changes.outputs.python == 'true' && needs.changes.outputs.narrow_python_only != 'true') || needs.changes.outputs.docs_test == 'true' || needs.changes.outputs.infra == 'true' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule' }}
runs-on: ubuntu-latest
timeout-minutes: 2

Expand All @@ -1989,7 +2002,7 @@ jobs:
test-docs:
needs: [changes, python-lint-types, docs-latex-unicode-guard]
# Run if docs changed OR Python changed OR infrastructure changed OR manual/scheduled run
if: ${{ (needs.changes.outputs.docs == 'true' && needs.changes.outputs.networkx_test_only != 'true' && needs.changes.outputs.benchmarks_only != 'true') || needs.changes.outputs.docs_test == 'true' || needs.changes.outputs.infra == 'true' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule' }}
if: ${{ (needs.changes.outputs.docs == 'true' && needs.changes.outputs.networkx_test_only != 'true' && needs.changes.outputs.benchmarks_only != 'true') || (needs.changes.outputs.python == 'true' && needs.changes.outputs.narrow_python_only != 'true') || needs.changes.outputs.docs_test == 'true' || needs.changes.outputs.infra == 'true' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule' }}
runs-on: ubuntu-latest
timeout-minutes: 10

Expand Down
Loading