feat(gfql/m2): route CALL/GRAPH compatibility through LogicalPlan - #1147
Merged
Merged
Conversation
lmeyerov
marked this pull request as ready for review
April 19, 2026 04:42
Contributor
Author
|
Re-audited PR #1147 ( Assessment: ✅ good to merge for M2-PR5 scope. What is covered:
Non-blocking caveat to track for M3:
|
This was referenced Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1128
Parent: #1139
Implements the M2-PR5 CALL/GRAPH compatibility lane by routing covered CALL shapes through explicit logical
ProcedureCalloperators while preserving existing runtime execution semantics.What changed
_logical_plan_route_for_query()now mapsquery.callto a verified logicalProcedureCalloperator.procedure,backend,algorithm,result_kind,row_kind, output columns, params) intoir.ProcedureCall+ output schema.CompiledCypherGraphQueryandCompiledGraphBindingnow include:logical_planlogical_plan_defer_reasonlogical_plan_route(derived)rowsandgraph).Behavior / Scope
Tests
PYTHONPATH=. uv run --no-project --with pytest python -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k "logical_plan_route_for_call_shape or graph_query_sets_logical_plan_route_for_call_constructor or graph_binding_call_constructor or graph_query_sets_logical_plan_defer_reason_for_match_constructor_shape"4 passedPYTHONPATH=. uv run --no-project --with pytest python -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k "call or graph or yield"698 passed, 59 skippedPYTHONPATH=. uv run --no-project --with pytest python -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py698 passed, 59 skippedPYTHONPATH=. uv run --no-project --with pytest python -m pytest -q graphistry/tests/compute/gfql/test_logical_planner.py graphistry/tests/compute/gfql/test_ir_verifier.py87 passed, 1 xfailed./bin/ruff.sh graphistry/compute/gfql/cypher/lowering.py graphistry/tests/compute/gfql/cypher/test_lowering.py graphistry/tests/compute/gfql/test_ir_verifier.pyMYPY_CACHE_DIR=/tmp/mypy_cache ./bin/mypy.sh graphistry/compute/gfql/cypher/lowering.pyLocal wave artifacts
(Tracked locally per workflow, not committed)
plans/1128-m2-pr5-call-graph-compat/plan.mdplans/1128-m2-pr5-call-graph-compat/findings/wave-1/spec-baseline.mdplans/1128-m2-pr5-call-graph-compat/findings/wave-1/post-fix-audit.mdplans/1128-m2-pr5-call-graph-compat/findings/wave-2/confirmation-audit.md