bug : Update gaussian_model.py 154-155 lines - #1333
Open
learnLearnDayUp wants to merge 1 commit into
Open
Conversation
Description : During code study, I found a minor issue in the create_from_pcd function when initializing SH features
Current code:
features[:, :3, 0] = fused_color
features[:, 3:, 1:] = 0.0
Proposed fix:
features[:, :, 0] = fused_color
features[:, :, 1:] = 0.0
Impact: No functional change, just code clarity improvement。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description : During code study, I found a minor issue in the create_from_pcd function when initializing SH features
Current code:
Problem:
The second dimension of features is exactly 3 (RGB channels), so :3 is redundant
features[:, 3:, 1:] will produce an empty slice since dimension 1 only has indices 0,1,2
Proposed fix:
This sets the DC component (index 0) for all RGB channels to the initial color, and zeros out all higher-order SH coefficients. The functionality remains identical, but the code is cleaner and avoids unnecessary slicing.
Impact: No functional change, just code clarity improvement。