tempodb: tolerate blocks removed during local listing - #7712
Open
arkoc wants to merge 1 commit into
Open
Conversation
Signed-off-by: Aram Kocharyan <aram.koch@gmail.com>
arkoc
requested review from
carles-grafana,
electron0zero,
ie-pham,
javiermolinar,
mapno,
mattdurham,
mdisibio,
ruslan-mikhailov,
stoewer,
yvrhdn,
zalegrala and
zhxiaogg
as code owners
August 10, 2026 23:37
Contributor
Signed commits report1 of 1 commit between
This repository requires all commits to be signed. See GitHub docs on commit signature verification. |
|
|
1 similar comment
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
The local backend blocklist poll and retention run on the same interval. When retention removes a compacted block directory while ListBlocks is walking the tenant directory, fs.WalkDir reports fs.ErrNotExist for that child and the entire tenant poll fails.
A concurrently removed child is no longer part of the blocklist, so this change skips only fs.ErrNotExist below the tenant root. Errors opening the tenant root and all other filesystem errors still fail the poll.
This was observed on v2.9.0, and the affected ListBlocks implementation is also present on release-v2.9. A backport would make the fix available to 2.9 users.
Testing