chore: revert verified-commit signing in provider tests & S/MIME github skip#376
Merged
MissingRoberto merged 1 commit intoJul 8, 2026
Merged
Conversation
…interim) (#357)" This reverts commit 19ae77b. Reverts the two interim test changes: - provider integration tests no longer GPG-sign commits / override the committer email for providers that require verified commits - re-enables S/MIME provider verification for github (removes the interim skip) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
MissingRoberto
requested review from
K-Phoen and
ferruvich
and removed request for
a team
MissingRoberto
changed the title
Codecov ReportCaution This repository is currently using the Sentry GitHub App to receive Codecov PR comments. This integration will be deprecated on July 8, 2026. Please install the Codecov GitHub App to continue receiving coverage reports on your pull requests. Additional details and impacted files@@ Coverage Diff @@
## main #376 +/- ##
==========================================
- Coverage 72.37% 72.34% -0.03%
==========================================
Files 59 59
Lines 7391 7391
==========================================
- Hits 5349 5347 -2
- Misses 1634 1636 +2
Partials 408 408 🚀 New features to boost your workflow:
|
amalavet
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts commit 19ae77b (#357), which introduced two interim test changes:
tests/providers_integration_test.go) — addedsignerForProvider, GPG-signing every provider write flow and overriding the committer/author email to the signing key whenTEST_GPG_KEY/TEST_SIGN_EMAILare set, so providers requiring verified commits would accept the push.tests/sign_providers_verify_test.go) — skipped the S/MIME provider verify case for github because a self-signed test cert can't chain to a CA in GitHub's trust store.Both interim workarounds are no longer needed: an exception has been added on the
nanogit-testrepository so its ruleset no longer requires verified commits. With that in place, the provider write flows don't need to GPG-sign / override the committer email, and the S/MIME github verification case can run without being rejected (GH013). This PR reverts both changes, restoring the tests to their pre-#357 state.go vet ./tests/passes.🤖 Generated with Claude Code