feat: add native incident.io Alertmanager receiver - #16522
Open
LukoJy3D wants to merge 1 commit into
Open
Conversation
Mimir already parsed incidentio_configs but never built a notifier, so those receivers silently dropped notifications. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Mimir already parsed incidentio_configs but never built a notifier, so those receivers silently dropped notifications.
Upstream Alertmanager added a native incident.io receiver in
0.29.0. Mimir started embedding a new enough library in3.1.0(Alertmanager v0.31.1; 3.0.x was still v0.28.1). From3.1.0onward Mimir unmarshalsincidentio_configs, somimirtool alertmanager getand the v2 alerts API show the receiver as selected.buildReceiverIntegrationsnever constructed a notifier fromIncidentioConfigs, so those receivers have been a silent no-op since 3.1.0: nointegration="incidentio"notification metrics or logs, while Slack/webhook_configs on the same alert still fire.This wires the existing
notify/incidentionotifier (same pattern as MS Teams V2), addsincidentiotoallowedIntegrationNames, and rejectsurl_file/alert_source_token_fileso tenant configs stay consistent with Mimir’s*_filesecret policy. Inlineurl+alert_source_tokenworks.Until this ships, the working workaround is webhook_configs with Bearer auth to the same URL, yet with high volume of alerts it can easily get rate limited from incident.io side
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]. If changelog entry is not needed, please add thechangelog-not-neededlabel to the PR.about-versioning.mdupdated with experimental features.