Added Support For Loading Video Dialog - #1
Open
thetutlage wants to merge 2 commits into
Open
Conversation
Added little more description about what's changed in the source code and now the activity will support loading video dialog box as well
…am.java Updated activity to show a dialog while we are busy loading video instead of showing a blank screen.
Owner
|
Thanks for your pull request. This repo is not meant to be a tutorial (especially since it doesn't work for me) nor I'm interested cosmetic features to it. I won't merge the pull request but will leave it open so that other people can locate your repo with UI improvements and check that out instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since you did a very nice job by creating this complete activity which takes care of playing video and screen orientation.
I added the support of dialog which will be shown while we are busy loading and setting video.
Let me know if you got any questions for me.