Turk/ci - #12
Conversation
|
@turkosaurus will you look at flutter_test.yml and make sure it looks ok? |
| echo "Current directory: $(pwd)" | ||
| echo "Contents of current directory:" | ||
| ls -la |
There was a problem hiding this comment.
Weird spacing and redundant. If you really want to keep it, clean it up.
| run: flutter build apk --release | ||
|
|
||
| - name: Build iOS (if applicable) | ||
| if: runner.os == 'macOS' |
There was a problem hiding this comment.
Does this not need the working dir option that android does?
There was a problem hiding this comment.
It does, and has one now. :)
| run: | | ||
| if [ ! -f "$HOME/flutter/bin/flutter" ]; then | ||
| echo "Flutter SDK not found. Downloading..." | ||
| git clone https://github.com/flutter/flutter.git -b stable --depth 1 $HOME/flutter |
There was a problem hiding this comment.
Note the depth option here of 1 is just one ref -- no history is included, just what's needed to build the latest ref.
There was a problem hiding this comment.
noted. Seems like a good way to go. Is there a reason I would want a different depth?
| - name: Debug Flutter SDK directory | ||
| run: ls -la $HOME/flutter/bin |
There was a problem hiding this comment.
Replace "debug" with something more descriptive like "list," unless debug is meant to be temporary. In which case, delete it.
|
@turkosaurus Will you review this and see if you think it is ready to merge to main? Can't ask for a review the normal way because this is your branch. |
2 participants
No description provided.