Use resources attribute for JVM classpath resources in kt_jvm_library#175
Merged
Merged
Conversation
vanminh-grabtaxi
requested review from
adarsh-grabtaxi,
arnav-grabtaxi,
arunsampathkumar-grabtaxi and
minkuanlim-grabtaxi
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Use resources attribute for JVM classpath resources in kt_jvm_library
Switch KotlinLibraryTarget from resource_files (Android-style) to the
resources attribute, which is the correct kt_jvm_library attribute for
JVM classpath resources such as service-loader registrations.
Issues Fixed