Skip to content

Fix issue after onboard latest cli version into Grab app #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akshay-grabtaxi merged 1 commit into from
May 6, 2026
Merged

Fix issue after onboard latest cli version into Grab app #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions app-sizer/src/main/kotlin/com/grab/sizer/report/MarkdownReportWriter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,29 +42,32 @@ class MarkdownReportWriter @Inject constructor(
private val projectInfo: ProjectInfo,
) : ReportWriter {
override fun write(report: Report) {
val header = report.createHeader()
File(File(outputDirectory, projectInfo.deviceName), "${report.id}-report.md").apply {
initOutPutFile()
writeText(
MarkdownTable(report.createHeader()).apply {
MarkdownTable(header).apply {
report.rows.forEach { row ->
addRow(row.toMarkDown())
addRow(row.toMarkDown(header.size))
}
}.generate()
)
}
}

private fun Row.toMarkDown(): List<String> {
return fields.map { field ->
private fun Row.toMarkDown(columnCount: Int): List<String> {
val values = fields.map { field ->
when (field.value) {
is Long -> (field.value as Long).reportSize()
else -> field.value.toString()
}
}
return if (values.size < columnCount) values + List(columnCount - values.size) { "NA" }
else values
}

private fun Report.createHeader(): List<String> {
return rows.firstOrNull()
return rows.maxByOrNull { it.fields.size }
?.fields
?.map { field ->
field.name.replaceFirstChar {
Expand Down
2 changes: 1 addition & 1 deletion cli/src/main/kotlin/com/grab/sizer/config/ProjectInput.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ class ProjectInputConfigDeserializer(vc: Class<*>? = null) : StdDeserializer<Pro
r8MappingFile = if (contains("r8-mapping-file")) File(get("r8-mapping-file").asText()) else null,
ownerMappingFile = if (contains("owner-mapping-file")) File(get("owner-mapping-file").asText()) else null,
libraryOwnerMappingFile = if (contains("library-owner-mapping-file")) File(get("library-owner-mapping-file").asText()) else null,
projectRoot = File(get("project-root-dir").asText()),
projectRoot = if (contains("project-root-dir")) File(get("project-root-dir").asText()) else File(get("modules-directory").asText()),
)
}
}
Loading