proxmox/chr_install.sh: verify CHR version exists; harden version handling - #17
Merged
Conversation
The NEWESTv7.<channel> path returns 404; the working path is NEWEST7.<channel>. Also reject placeholder values like '0.00' so an empty branch does not get offered as a default version.
…atest lookup MikroTik's legacy NEWEST*/LATEST.* version feeds are frozen at 7.12.1 and no longer reflect current releases, so auto-suggesting a 'latest' version was misleading. Replace it with a prompt loop that validates the version format and confirms the CHR image actually exists on the download server (HEAD request) before proceeding, re-prompting on invalid/missing versions. Point users to https://mikrotik.com/download for current Long-term/Stable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #16.
MikroTik's legacy
NEWEST*/LATEST.*version feeds turned out to be frozen at 7.12.1 (Nov 2023) and no longer reflect current releases, so auto-suggesting a "latest" version was misleading.Changes:
wget --spider) before proceeding, re-prompting on invalid/missing versions.https://claude.ai/code/session_016rtazH8tiWw4fqCuLcEPFC
Generated by Claude Code