change yarn telemetry to opt-in

[eternal-flame-AD]

Since we upgraded UI I think we should disable the telemetries newer yarn versions have by default. This sets a default disable for package manager repositories for all builders, users can still opt-in with --enableTelemetry.

The legal reasoning is since we hide yarn behind make I don't really think telling the user to run make build-js counts as providing giving users an opportunity to consent.

The technical reasoning is they claim the reason as:

"Various threads in the Node docker image repositories suggested to remove Yarn from the Docker image ... because of the lack of telemetry, some projects also had trouble taking us seriously." documentation

Where? I gave it a quick check and I do not see such debates (at least the problem is not simply "I don't think it is popular enough"). Most are functional, cost, SBOM and security concerns. I don't really believe the appropriate way to be "taken seriously" out of these issues is numerically monetizing your users for your project continuity without an explicit consent.

I also don't see similar telemetry systems being coded into the NPM or PNPM command line. Go also has telemetry but they are opt-in and thus we are not making a choice on behalf of users. Yarn's opt-out approach feels particularly aggressive to me.

Their RFC: yarnpkg/berry#1250

[jmattheis]

Thanks, I didn't knew yarn had this feature.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.54%. Comparing base (ebf6a64) to head (400cf8b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #823   +/-   ##
=======================================
  Coverage   79.54%   79.54%           
=======================================
  Files          56       56           
  Lines        2645     2645           
=======================================
  Hits         2104     2104           
  Misses        450      450           
  Partials       91       91           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.