Skip to content

switch to mobx-react-lite - #822

Merged
eternal-flame-AD merged 1 commit into
masterfrom
upgrade-ui-mobx
Aug 8, 2025
Merged

switch to mobx-react-lite#822
eternal-flame-AD merged 1 commit into
masterfrom
upgrade-ui-mobx

Conversation

@eternal-flame-AD

Copy link
Copy Markdown
Member

Since we switched to functional components we can use the lite version.

We are already using it in a transitive way which only works on older package managers and can potentially link differently and it needs to be reconciled.

import {observer} from 'mobx-react-lite';

@eternal-flame-AD
eternal-flame-AD requested a review from a team as a code owner August 8, 2025 00:32
@codecov

codecov Bot commented Aug 8, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.54%. Comparing base (ea1cc38) to head (a32564f).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #822   +/-   ##
=======================================
  Coverage   79.54%   79.54%           
=======================================
  Files          56       56           
  Lines        2645     2645           
=======================================
  Hits         2104     2104           
  Misses        450      450           
  Partials       91       91           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jmattheis
jmattheis changed the base branch from upgrade-ui to master August 8, 2025 09:03

@jmattheis jmattheis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
@eternal-flame-AD
eternal-flame-AD merged commit ba3bd1b into master Aug 8, 2025
4 checks passed
@jmattheis
jmattheis deleted the upgrade-ui-mobx branch August 9, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants